Skip to content

WIP-Adding Prov env info #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

WIP-Adding Prov env info #598

wants to merge 7 commits into from

Conversation

rcali21
Copy link
Contributor

@rcali21 rcali21 commented Nov 27, 2022

Types of changes

  • New feature (non-breaking change which adds functionality)

Summary

Gets env info for PROV tracking.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@rcali21 rcali21 changed the title Prov env WIP-Adding Prov env info Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.80%. Comparing base (662ade1) to head (186bd09).
Report is 1105 commits behind head on main.

Files with missing lines Patch % Lines
pydra/engine/audit.py 72.72% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   76.81%   76.80%   -0.02%     
==========================================
  Files          19       19              
  Lines        4357     4367      +10     
  Branches     1194     1195       +1     
==========================================
+ Hits         3347     3354       +7     
- Misses        821      823       +2     
- Partials      189      190       +1     
Flag Coverage Δ
unittests 76.71% <72.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose added the to consider suggesting changes that require more discussion label Apr 2, 2025
@tclose
Copy link
Contributor

tclose commented Apr 2, 2025

this should still be valid shouldn't it?

@satra
Copy link
Contributor

satra commented Apr 2, 2025

given changes in environments, it may be worthwhile to redo this in that context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to consider suggesting changes that require more discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants